aboutsummaryrefslogtreecommitdiff
path: root/layers/buffer_validation.cpp
diff options
context:
space:
mode:
authorChris Forbes <chrisforbes@google.com>2017-06-14 12:38:01 -0700
committerChris Forbes <chrisf@ijw.co.nz>2017-06-15 09:50:14 -0700
commit6d342fcee9f5a934ce892a1db7a7afa970f6a127 (patch)
tree1f57107fc55adffa75476fb433213e15c27973c7 /layers/buffer_validation.cpp
parent61733037abccf5f48276983dd6f6094062cfe21c (diff)
downloadusermoji-6d342fcee9f5a934ce892a1db7a7afa970f6a127.tar.xz
layers: Clean up missing checks list for vkCreateBuffer
Diffstat (limited to 'layers/buffer_validation.cpp')
-rw-r--r--layers/buffer_validation.cpp15
1 files changed, 7 insertions, 8 deletions
diff --git a/layers/buffer_validation.cpp b/layers/buffer_validation.cpp
index 50763760..f04f74f3 100644
--- a/layers/buffer_validation.cpp
+++ b/layers/buffer_validation.cpp
@@ -2890,10 +2890,7 @@ bool PreCallValidateCreateBuffer(layer_data *device_data, const VkBufferCreateIn
bool skip = false;
const debug_report_data *report_data = core_validation::GetReportData(device_data);
- // TODO: Add check for VALIDATION_ERROR_1ec0071e
- // TODO: Add check for VALIDATION_ERROR_01400728
- // TODO: Add check for VALIDATION_ERROR_0140072a
- // TODO: Add check for VALIDATION_ERROR_0140072c
+ // TODO: Add check for VALIDATION_ERROR_1ec0071e (sparse address space accounting)
if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!GetEnabledFeatures(device_data)->sparseBinding)) {
skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
@@ -2906,17 +2903,19 @@ bool PreCallValidateCreateBuffer(layer_data *device_data, const VkBufferCreateIn
if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!GetEnabledFeatures(device_data)->sparseResidencyBuffer)) {
skip |=
log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
- DRAWSTATE_INVALID_FEATURE, "DS",
+ VALIDATION_ERROR_01400728, "DS",
"vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with the "
- "VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set.");
+ "VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set. %s",
+ validation_error_map[VALIDATION_ERROR_01400728]);
}
if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!GetEnabledFeatures(device_data)->sparseResidencyAliased)) {
skip |=
log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__,
- DRAWSTATE_INVALID_FEATURE, "DS",
+ VALIDATION_ERROR_0140072a, "DS",
"vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with the "
- "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set.");
+ "VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set. %s",
+ validation_error_map[VALIDATION_ERROR_0140072a]);
}
return skip;
}