diff options
| author | Tobin Ehlis <tobin@lunarg.com> | 2015-07-13 13:42:25 -0600 |
|---|---|---|
| committer | Courtney Goeltzenleuchter <courtney@LunarG.com> | 2015-07-17 10:05:22 -0600 |
| commit | f492e04436ff033d07f54fda7e3d13f65a8ff99f (patch) | |
| tree | 1aca865362c2c2706de6b2feb02f507c69b4e3ce | |
| parent | a8b2d2b6e13fcb6b0bb1dd6cc2b608607c661319 (diff) | |
| download | usermoji-f492e04436ff033d07f54fda7e3d13f65a8ff99f.tar.xz | |
layers: MemTracker fix to skip COLOR usage bit check for now
Now that Attachments are generalized and not color or DS specific, need to make sure we only check usage bits appropriate for a given image.
| -rw-r--r-- | layers/mem_tracker.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/layers/mem_tracker.cpp b/layers/mem_tracker.cpp index 31f50755..4f0da34d 100644 --- a/layers/mem_tracker.cpp +++ b/layers/mem_tracker.cpp @@ -2132,7 +2132,7 @@ VK_LAYER_EXPORT VkResult VKAPI vkCreateImageView( } VK_LAYER_EXPORT VkResult VKAPI vkCreateAttachmentView( - VkDevice device, + VkDevice device, const VkAttachmentViewCreateInfo *pCreateInfo, VkAttachmentView *pView) { @@ -2145,8 +2145,10 @@ VK_LAYER_EXPORT VkResult VKAPI vkCreateAttachmentView( MT_OBJ_BINDING_INFO* pInfo = get_object_binding_info(pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE); if (pInfo) { if (VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO == pInfo->create_info.image.sType) { - validate_usage_flags(device, pInfo->create_info.image.usage, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, true, - pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE, "image", "vkCreateAttachmentView()", "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT"); + // TODO : Now that this is generalized for all Attachments, need to only check COLOR or DS USAGE bits + // if/when we know that Image being attached to is Color or DS. Can probably do this for DS based on format +// validate_usage_flags(device, pInfo->create_info.image.usage, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, true, +// pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE, "image", "vkCreateAttachmentView()", "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT"); } else if (VK_STRUCTURE_TYPE_SWAP_CHAIN_CREATE_INFO_WSI == pInfo->create_info.swapchain.sType) { validate_usage_flags(device, pInfo->create_info.swapchain.imageUsageFlags, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, true, pCreateInfo->image.handle, VK_OBJECT_TYPE_IMAGE, "image", "vkCreateAttachmentView()", "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT"); |