aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLiam Middlebrook <lmiddlebrook@nvidia.com>2018-03-19 12:28:04 -0700
committerMark Lobodzinski <mark@lunarg.com>2018-03-20 11:06:14 -0600
commitecd3f85fc68c0e33e1340460839151a4fe178f90 (patch)
tree5c7d4464e7df2197a2ef4a94c36cce907a7250cb
parent81a41cc32834effc1605b2f3b54e2f0e86b2c569 (diff)
downloadusermoji-ecd3f85fc68c0e33e1340460839151a4fe178f90.tar.xz
layers: Fix Superfluous inttypes.h Includes
The files that explicitly include <inttypes.h> are C++ files. The convention for including C header files in C++ programs is to use a special C++ header file that wraps the C header file. For example <inttypes.h> would be included as <cinttypes>. In vk_layer_logging.h:34 <cinttypes> is included. In buffer_validation.cpp and parameter_validation_utils.cpp "vk_layer_logging.h" is directly included. In core_validation.cpp "vk_layer_logging.h" is indirectly included via core_validation.h This change removes the invalid and superfluous use of C header files from the aforementioned C++ files. Change-Id: I1bed9ea4bf6c3bb98ac5ae05ad227c0da58acb2c Reviewed-by: dkoch Reviewed-by: ddadap
-rw-r--r--layers/buffer_validation.cpp1
-rw-r--r--layers/core_validation.cpp1
-rw-r--r--layers/parameter_validation_utils.cpp1
3 files changed, 0 insertions, 3 deletions
diff --git a/layers/buffer_validation.cpp b/layers/buffer_validation.cpp
index ac332d8b..518bcfd8 100644
--- a/layers/buffer_validation.cpp
+++ b/layers/buffer_validation.cpp
@@ -22,7 +22,6 @@
// Allow use of STL min and max functions in Windows
#define NOMINMAX
-#include <inttypes.h>
#include <sstream>
#include <string>
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp
index 3879ae4f..57ea4658 100644
--- a/layers/core_validation.cpp
+++ b/layers/core_validation.cpp
@@ -51,7 +51,6 @@
#include <string.h>
#include <string>
#include <valarray>
-#include <inttypes.h>
#include "vk_loader_platform.h"
#include "vk_dispatch_table_helper.h"
diff --git a/layers/parameter_validation_utils.cpp b/layers/parameter_validation_utils.cpp
index 69f12837..e74a846a 100644
--- a/layers/parameter_validation_utils.cpp
+++ b/layers/parameter_validation_utils.cpp
@@ -25,7 +25,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <inttypes.h>
#include <iostream>
#include <string>