diff options
| author | Mark Lobodzinski <mark@lunarg.com> | 2015-03-05 10:07:53 -0600 |
|---|---|---|
| committer | Mark Lobodzinski <mark@lunarg.com> | 2015-03-16 13:53:18 -0500 |
| commit | 68a3749b2e2d4726dc79c77c90615e0a4b80ccaf (patch) | |
| tree | 9ce048d98ec6087b75cd7a6f341c47848915690f | |
| parent | 8247e999ddb14b8ca7e09e1ddbbf6024d5f0fd83 (diff) | |
| download | usermoji-68a3749b2e2d4726dc79c77c90615e0a4b80ccaf.tar.xz | |
layers: Reduce unmeaningful error messages for memtracker
It is a common case for a command buffer not to have a fence associated
with it -- no reason to call these cases out as errors.
| -rw-r--r-- | layers/mem_tracker.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/layers/mem_tracker.c b/layers/mem_tracker.c index 7b2e009c..228dc45f 100644 --- a/layers/mem_tracker.c +++ b/layers/mem_tracker.c @@ -283,11 +283,7 @@ static void clearCBBinding(const XGL_CMD_BUFFER cb, const XGL_GPU_MEMORY mem) pPrev = pMiniCB; pMiniCB = pMiniCB->pNext; } - if (!pMiniCB) { - char str[1024]; - sprintf(str, "Trying to clear CB binding but CB %p not in binding list for mem obj %p", cb, mem); - layerCbMsg(XGL_DBG_MSG_ERROR, XGL_VALIDATION_LEVEL_0, cb, 0, MEMTRACK_INTERNAL_ERROR, "MEM", str); - } else { // remove node from list & decrement refCount + if (pMiniCB) { // remove node from list & decrement refCount pPrev->pNext = pMiniCB->pNext; if (pMiniCB == pTrav->pCmdBufferBindings) pTrav->pCmdBufferBindings = NULL; @@ -428,12 +424,7 @@ static bool32_t checkCBCompleted(const XGL_CMD_BUFFER cb) layerCbMsg(XGL_DBG_MSG_ERROR, XGL_VALIDATION_LEVEL_0, cb, 0, MEMTRACK_INVALID_CB, "MEM", str); result = XGL_FALSE; } else { - if (!pCBTrav->fence) { - char str[1024]; - sprintf(str, "No fence found for CB %p to check for completion", cb); - layerCbMsg(XGL_DBG_MSG_ERROR, XGL_VALIDATION_LEVEL_0, cb, 0, MEMTRACK_CB_MISSING_FENCE, "MEM", str); - result = XGL_FALSE; - } else { + if (pCBTrav->fence) { if (XGL_SUCCESS != nextTable.GetFenceStatus(pCBTrav->fence)) { char str[1024]; sprintf(str, "Fence %p for CB %p has not completed", pCBTrav->fence, cb); |