diff options
| author | Tobin Ehlis <tobine@google.com> | 2016-10-25 15:23:08 -0600 |
|---|---|---|
| committer | Tobin Ehlis <tobine@google.com> | 2016-10-25 20:41:23 -0600 |
| commit | 41b684a8fc0efb0951e0c8b2c8f52058d25ecb63 (patch) | |
| tree | ecb6957b013e401908c7dc951bc124caee96316d | |
| parent | b8ee084205c8b61d10238813bbc5814a6860ce32 (diff) | |
| download | usermoji-41b684a8fc0efb0951e0c8b2c8f52058d25ecb63.tar.xz | |
layers:Rename cmd buffer flags for clarity
Fixes #870
CBSTATUS_ALL was not clear so changed to more descriptive
CBSTATUS_ALL_STATE_SET. This mask is used to flag all of the pipeline
state for a cmd buffer as "set." The setting can then be adjusted based
on which state was flagged as dynamic in the pipeline state object.
| -rw-r--r-- | layers/core_validation.cpp | 4 | ||||
| -rw-r--r-- | layers/core_validation_types.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp index 0390dc3d..e07929da 100644 --- a/layers/core_validation.cpp +++ b/layers/core_validation.cpp @@ -4205,12 +4205,12 @@ static void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe) // Account for any dynamic state not set via this PSO if (!pPipe->graphicsPipelineCI.pDynamicState || !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static - pCB->status |= CBSTATUS_ALL; + pCB->status |= CBSTATUS_ALL_STATE_SET; } else { // First consider all state on // Then unset any state that's noted as dynamic in PSO // Finally OR that into CB statemask - CBStatusFlags psoDynStateMask = CBSTATUS_ALL; + CBStatusFlags psoDynStateMask = CBSTATUS_ALL_STATE_SET; for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { case VK_DYNAMIC_STATE_LINE_WIDTH: diff --git a/layers/core_validation_types.h b/layers/core_validation_types.h index 6539d837..592d4911 100644 --- a/layers/core_validation_types.h +++ b/layers/core_validation_types.h @@ -399,7 +399,7 @@ enum CBStatusFlagBits { CBSTATUS_STENCIL_WRITE_MASK_SET = 0x00000020, // Stencil write mask has been set CBSTATUS_STENCIL_REFERENCE_SET = 0x00000040, // Stencil reference has been set CBSTATUS_INDEX_BUFFER_BOUND = 0x00000080, // Index buffer has been set - CBSTATUS_ALL = 0x0000007F, // All dynamic state set (intentionally exclude index buffer) + CBSTATUS_ALL_STATE_SET = 0x0000007F, // All state set (intentionally exclude index buffer) // clang-format on }; |