From 39d77475d383cea2aaee5deaf7235306b64b6d1d Mon Sep 17 00:00:00 2001 From: mat Date: Fri, 22 Apr 2022 04:37:45 +0000 Subject: remove some useless code --- azalea-nbt/src/encode.rs | 68 +++++++++++++++--------------------------------- 1 file changed, 21 insertions(+), 47 deletions(-) diff --git a/azalea-nbt/src/encode.rs b/azalea-nbt/src/encode.rs index 9ce4faf4..51c5968c 100755 --- a/azalea-nbt/src/encode.rs +++ b/azalea-nbt/src/encode.rs @@ -6,12 +6,8 @@ use std::io::Write; #[inline] fn write_string(writer: &mut dyn Write, string: &str) -> Result<(), Error> { - writer - .write_i16::(string.len() as i16) - .map_err(|_| Error::WriteError)?; - writer - .write_all(string.as_bytes()) - .map_err(|_| Error::WriteError)?; + writer.write_i16::(string.len() as i16)?; + writer.write_all(string.as_bytes())?; Ok(()) } @@ -20,28 +16,16 @@ impl Tag { pub fn write_without_end(&self, writer: &mut dyn Write) -> Result<(), Error> { match self { Tag::End => {} - Tag::Byte(value) => writer.write_i8(*value).map_err(|_| Error::WriteError)?, - Tag::Short(value) => writer - .write_i16::(*value) - .map_err(|_| Error::WriteError)?, - Tag::Int(value) => writer - .write_i32::(*value) - .map_err(|_| Error::WriteError)?, - Tag::Long(value) => writer - .write_i64::(*value) - .map_err(|_| Error::WriteError)?, - Tag::Float(value) => writer - .write_f32::(*value) - .map_err(|_| Error::WriteError)?, - Tag::Double(value) => writer - .write_f64::(*value) - .map_err(|_| Error::WriteError)?, + Tag::Byte(value) => writer.write_i8(*value)?, + Tag::Short(value) => writer.write_i16::(*value)?, + Tag::Int(value) => writer.write_i32::(*value)?, + Tag::Long(value) => writer.write_i64::(*value)?, + Tag::Float(value) => writer.write_f32::(*value)?, + Tag::Double(value) => writer.write_f64::(*value)?, Tag::ByteArray(value) => { - writer - .write_i32::(value.len() as i32) - .map_err(|_| Error::WriteError)?; + writer.write_i32::(value.len() as i32)?; for &byte in value { - writer.write_i8(byte).map_err(|_| Error::WriteError)?; + writer.write_i8(byte)?; } } Tag::String(value) => { @@ -50,14 +34,12 @@ impl Tag { Tag::List(value) => { // we just get the type from the first item, or default the type to END if value.is_empty() { - writer.write_i8(0).map_err(|_| Error::WriteError)?; - writer.write_i32::(0).map_err(|_| Error::WriteError)?; + writer.write_i8(0)?; + writer.write_i32::(0)?; } else { let type_id = value[0].id(); - writer.write_u8(type_id).map_err(|_| Error::WriteError)?; - writer - .write_i32::(value.len() as i32) - .map_err(|_| Error::WriteError)?; + writer.write_u8(type_id)?; + writer.write_i32::(value.len() as i32)?; for tag in value { tag.write_without_end(writer)?; } @@ -65,30 +47,22 @@ impl Tag { } Tag::Compound(value) => { for (key, tag) in value { - writer.write_u8(tag.id()).map_err(|_| Error::WriteError)?; + writer.write_u8(tag.id())?; write_string(writer, key)?; tag.write_without_end(writer)?; } - writer - .write_u8(Tag::End.id()) - .map_err(|_| Error::WriteError)?; + writer.write_u8(Tag::End.id())?; } Tag::IntArray(value) => { - writer - .write_i32::(value.len() as i32) - .map_err(|_| Error::WriteError)?; + writer.write_i32::(value.len() as i32)?; for &int in value { - writer.write_i32::(int).map_err(|_| Error::WriteError)?; + writer.write_i32::(int)?; } } Tag::LongArray(value) => { - writer - .write_i32::(value.len() as i32) - .map_err(|_| Error::WriteError)?; + writer.write_i32::(value.len() as i32)?; for &long in value { - writer - .write_i64::(long) - .map_err(|_| Error::WriteError)?; + writer.write_i64::(long)?; } } } @@ -100,7 +74,7 @@ impl Tag { match self { Tag::Compound(value) => { for (key, tag) in value { - writer.write_u8(tag.id()).map_err(|_| Error::WriteError)?; + writer.write_u8(tag.id())?; write_string(writer, key)?; tag.write_without_end(writer)?; } -- cgit v1.2.3